Nabutso wrote:
I dont think you understand how significant the changes have been in the past several years since the split.
Regardless, nas has been working on a fix from the information form their fix. Dunno his current status on it though.
Unless Nas has introduced a new and different bug causing auto homepointing, then it should be 100% possible utilizing git to walk through the changes and figure out how DSP fixed it and give him most of the solution for fixing it here.
Unless he also doesn't understand how the code has changed here, doesn't have his own source and revision control in place, and doesn't have good comments.
Professional software developers deal with taking in changes from software forks that have diverged hugely and significantly all the time.
And the thing with bugs is that if they share a common origin, even if tens or hundreds of thousands of lines of code have changed around them, the part that has the bug probably hasn't changed much, otherwise the bug probably would be gone, too. ~4million lines of code change every year in the Linux kernel, and bugs that were introduced years prior that have stuck around to the present are often still fixed with basically the same change regardless of the version.
But even if it isn't that simple, proper software development practices should make using at least the core concept's of DSP's fixes something that takes a week or two of effort at the extreme end. The nature of running an emulated server also means that the nature of some systems and changes are constrained in how much they can diverge to begin with.
https://github.com/DarkstarProject/darkstar/pull/5245 appears to be the fix. The fix to DSP is not particularly complicated - the reversing work would be the hard part. With the details in the pull request and the relatively straightforward changes, I would bet good money that this is not a hugely difficult issue to resolve in the Nasomi codebase. Many of the commits in the pull request look to not even be necessary for resolving the homepoint issue, but appear to be more housekeeping commits to get things to work more inline with retail's implementation.
_________________
PhD Shitposting 2037 | Cthalupa 75 BLM BRD RNG RDM WAR | Cathatwopa 75 NIN THF BLU BRD PLD
http://rfklinkshell.com/